frontend/src/routes/(app)/(internal)/[model=urlmodel]/export/+server.ts (1)

Line range hint 14-21: Sanitize the filename to ensure compatibility.

The current filename includes special characters from toISOString() which might cause issues. Consider sanitizing it.

-	const fileName = `${URLModel}-${new Date().toISOString()}.csv`;
+	const timestamp = new Date().toISOString().replace(/[:.]/g, '-');
+	const fileName = `${URLModel}-${timestamp}.csv`;
 
 	return new Response(await res.blob(), {
 		headers: {
 			'Content-Type': 'text/csv',
 			'Content-Disposition': `attachment; filename="${fileName}"`
 		}
 	});

frontend/src/routes/(app)/(third-party)/[model=thirdparty_urlmodels]/+page.svelte (1)

Line range hint 69-75: Consider extracting shared export button logic.

The export button condition ['applied-controls', 'assets'].includes(URLModel) is duplicated across components. Consider extracting this into a shared constant or utility function.

Also, enhance accessibility by adding an aria-label to the export button:

 <a
   href="{URLModel}/export/"
   class="inline-block p-3 text-gray-50 bg-pink-500 hover:bg-pink-400 w-12 focus:relative"
   title={m.exportButton()}
+  aria-label={m.exportButton()}
   data-testid="export-button"><i class="fa-solid fa-download mr-2" /></a
 >

frontend/src/routes/(app)/(internal)/[model=urlmodel]/+page.svelte (1)

Line range hint 150-157: Align button styling with third-party component.

The export button uses different styling classes between internal and third-party components. Consider using consistent styling:

• Internal: btn-mini-tertiary
• Third-party: text-gray-50 bg-pink-500 hover:bg-pink-400

Also, add aria-label for accessibility:

 <a
   href="{URLModel}/export/"
   class="inline-block p-3 btn-mini-tertiary w-12 focus:relative"
   title={m.exportButton()}
+  aria-label={m.exportButton()}
   data-testid="export-button"><i class="fa-solid fa-download mr-2" /></a
 >

backend/core/views.py (1)

511-550: Implementation looks good with some suggestions for improvement.

The CSV export functionality is well-implemented with proper permission checks and data handling. Consider these improvements:

1. For large datasets, consider implementing pagination or streaming to reduce memory usage.
2. Add error handling for potential exceptions during CSV generation.

Example implementation with streaming and error handling:

@action(detail=False, name="Export assets as CSV")
def export_csv(self, request):
    try:
        (viewable_assets_ids, _, _) = RoleAssignment.get_accessible_object_ids(
            Folder.get_root_folder(), request.user, Asset
        )
        response = HttpResponse(content_type="text/csv")
        response["Content-Disposition"] = 'attachment; filename="assets_export.csv"'

        writer = csv.writer(response, delimiter=";")
        columns = [
            "internal_id",
            "name",
            "description",
            "type",
            "security_objectives",
            "disaster_recovery_objectives",
            "link",
            "owners",
            "parent_assets",
            "labels",
        ]
        writer.writerow(columns)

+       # Use iterator() to reduce memory usage
+       for asset in Asset.objects.filter(id__in=viewable_assets_ids).iterator():
            row = [
                asset.id,
                asset.name,
                asset.description,
                asset.type,
                asset.get_security_objectives_display(),
                asset.get_disaster_recovery_objectives_display(),
                asset.reference_link,
                ",".join([o.email for o in asset.owner.all()]),
                ",".join([o.name for o in asset.parent_assets.all()]),
                ",".join([o.label for o in asset.filtering_labels.all()]),
            ]
            writer.writerow(row)

        return response
+   except Exception as e:
+       logger.error(f"Error exporting assets to CSV: {str(e)}")
+       return HttpResponse(
+           status=500,
+           content="An error occurred while generating the CSV export."
+       )

🧰 Tools

🪛 Ruff (0.8.2)

514-514: Asset may be undefined, or defined from star imports

(F405)

---

534-534: Asset may be undefined, or defined from star imports

(F405)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

backend/core/views.py (2)

511-564: Good implementation with room for improvement.

The CSV export implementation is solid with proper permission handling, error handling, and memory-efficient iteration. Consider these enhancements:

1. Make the filename more descriptive by including a timestamp and domain/folder name.
2. Allow configurable CSV delimiter through settings or request parameters.
3. Add content encoding specification to handle special characters correctly.
4. Consider implementing progress tracking for large datasets.

Here's a suggested improvement:

-            response["Content-Disposition"] = 'attachment; filename="assets_export.csv"'
+            timestamp = timezone.now().strftime("%Y%m%d_%H%M%S")
+            filename = f"assets_export_{timestamp}.csv"
+            response["Content-Disposition"] = f'attachment; filename="{filename}"'
+            response["Content-Type"] = "text/csv; charset=utf-8"

🧰 Tools

🪛 Ruff (0.8.2)

515-515: Asset may be undefined, or defined from star imports

(F405)

---

535-535: Asset may be undefined, or defined from star imports

(F405)

---

Line range hint 1-1: Replace star imports with explicit imports for better maintainability.

The static analysis tool indicates that Asset may be undefined. While it's imported through .models import *, explicit imports make dependencies clearer and improve code maintainability.

Replace the star import with explicit imports:

-from .models import *
+from .models import (
+    Asset,
+    Evidence,
+    FilteringLabel,
+    # Add other required models...
+)

🧰 Tools

🪛 Ruff (0.8.2)

509-509: Asset may be undefined, or defined from star imports

(F405)

---

515-515: Asset may be undefined, or defined from star imports

(F405)

---

535-535: Asset may be undefined, or defined from star imports

(F405)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro